TST: Test pd.Grouper base floating point error (#25161) #26240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
requested changes
Apr 29, 2019
WillAyd
added
Groupby
Testing
Codecov Report
@@ Coverage Diff @@
## master #26240 +/- ##
==========================================
- Coverage 91.97% 91.96% -0.01%
==========================================
Files 175 175
Lines 52368 52368
==========================================
- Hits 48164 48161 -3
- Misses 4204 4207 +3
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26240 +/- ##
==========================================
+ Coverage 91.97% 91.97% +<.01%
==========================================
Files 175 175
Lines 52368 52386 +18
==========================================
+ Hits 48164 48181 +17
- Misses 4204 4205 +1
Continue to review full report at Codecov.
|
jreback
requested changes
Apr 30, 2019
| @@ -303,6 +303,18 @@ def test_grouper_getting_correct_binner(self): | |||
| def test_grouper_iter(self, df): | |||
| assert sorted(df.groupby('A').grouper) == ['bar', 'foo'] | |||
|
|
|||
| def test_grouper_base(self): | |||
There was a problem hiding this comment.
can you move to test pandas/tests/resample/test_timegrouper and also test in .resample (which is what this calls)
Use resample() which is what Grouper calls, assert index instead of result of size()
gfyoung
reviewed
May 2, 2019
jreback
approved these changes
May 2, 2019
|
thanks @ihsansecer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff